Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dance: Twirl #94

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Dance: Twirl #94

wants to merge 5 commits into from

Conversation

felky
Copy link

@felky felky commented Oct 10, 2018

Plays with rotation3d for a cool twirl effect!

@Okazari
Copy link
Owner

Okazari commented Oct 11, 2018

Wow sounds nice !!
Gonna review it asa i have free time ;)

@Okazari
Copy link
Owner

Okazari commented Oct 28, 2018

Hey. Sorry for the delay. I've been really busy theses days. Gonna give it a look asap to merge it before the end of the month

Okazari
Okazari reviewed Oct 28, 2018
View reviewed changes
Copy link
Owner

@Okazari Okazari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Gonna test it asap :)

Okazari
Okazari requested changes Apr 8, 2019
View reviewed changes
Copy link
Owner

@Okazari Okazari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaaaaaaaaaand sorry again for the delay. I just checked out your dance and i got some feedbacks :)

I feel that this is a bit too close to the "twist" dance. Do you think you could exagerate a bit more on the 3D part of the effect ?

Thanks in advance 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okazari Okazari Okazari requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felky @Okazari