-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dance: Twirl #94
base: master
Are you sure you want to change the base?
Add Dance: Twirl #94
Conversation
Add twirl
Add Twirl to the demo site
Add twirl to the example.js
Wow sounds nice !! |
Hey. Sorry for the delay. I've been really busy theses days. Gonna give it a look asap to merge it before the end of the month |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Gonna test it asap :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaaaaaaaaaand sorry again for the delay. I just checked out your dance and i got some feedbacks :)
I feel that this is a bit too close to the "twist" dance. Do you think you could exagerate a bit more on the 3D part of the effect ?
Thanks in advance 😄
Plays with rotation3d for a cool twirl effect!